Skip to content

Conversation

snowystinger
Copy link
Member

Closes

For consideration. We need to allow for more style overrides in Table Cells, it's hard to align text vertically in anything other than center. This is also due to us having a cell content wrapper. So we have another avenue we could explore by allowing people to have that element not rendered.
We could also limit the set of allowed overrideable styles, but right now we don't have a set that allows for this particular override.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

...tableVisualOptions,
isDivider: showDivider
})}
}), props.styles)}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Span still gets in the way of custom styling like we'd normally allow for a container type of element

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant